Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use join for check-by-address path #7062

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix: use join for check-by-address path #7062

merged 2 commits into from
Feb 9, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Feb 9, 2024

closes #7051

use Url::join to ensure the url is /path

@mattsse mattsse mentioned this pull request Feb 9, 2024
Closed
2 tasks
@DaniPopes
Copy link
Member

DaniPopes commented Feb 9, 2024 •
edited
Loading

Can you pls rebase to run CI #7064

@mattsse mattsse merged commit 6be2e77 into foundry-rs:master Feb 9, 2024
18 of 19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Evalir approved these changes

@onbjerg onbjerg onbjerg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forge verify-check fails without trailing slash in verifier url
4 participants
@mattsse @DaniPopes @onbjerg @Evalir